netdev - Re: [PATCH 0/2] net/usb/ax88179_178a: Adjustments for ax88179_chk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180310191744.GN27783@lunn.ch>
Date:   Sat, 10 Mar 2018 20:17:44 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     SF Markus Elfring <elfring@...rs.sourceforge.net>
Cc:     linux-usb@...r.kernel.org, netdev@...r.kernel.org,
        "Andrew F. Davis" <afd@...com>,
        Bjørn Mork <bjorn@...k.no>,
        "David S. Miller" <davem@...emloft.net>,
        Philippe Reynes <tremyfr@...il.com>,
        Yuval Shaia <yuval.shaia@...cle.com>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 0/2] net/usb/ax88179_178a: Adjustments for
 ax88179_chk_eee()

On Sat, Mar 10, 2018 at 07:22:55PM +0100, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Sat, 10 Mar 2018 19:05:45 +0100
> 
> Two update suggestions were taken into account
> from static source code analysis.

Hi Markus

How about re-writing this driver to use phylib. The whole of
ax88179_chk_eee() would then go away, since it is a duplication of
phy_init_eee().

	Andrew