netdev - Re: [PATCH net-next 1/3] net: ipv6: Introduce ip6_multipath_hash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20187fe9-bd4b-c1d9-acfc-0bf65a23077e@gmail.com>
Date:   Sun, 11 Mar 2018 20:12:17 -0600
From:   David Ahern <dsahern@...il.com>
To:     Ido Schimmel <idosch@...lanox.com>, netdev@...r.kernel.org
Cc:     davem@...emloft.net, petrm@...lanox.com, jiri@...lanox.com,
        mlxsw@...lanox.com
Subject: Re: [PATCH net-next 1/3] net: ipv6: Introduce
 ip6_multipath_hash_policy()

On 3/11/18 12:45 AM, Ido Schimmel wrote:
> From: Petr Machata <petrm@...lanox.com>
> 
> In order to abstract away access to the
> ipv6.sysctl.multipath_hash_policy variable, which is not available on
> systems compiled without IPv6 support, introduce a wrapper function
> ip6_multipath_hash_policy() that falls back to 0 on non-IPv6 systems.
> 
> Use this wrapper from mlxsw/spectrum_router instead of a direct
> reference.
> 
> Signed-off-by: Petr Machata <petrm@...lanox.com>
> Signed-off-by: Ido Schimmel <idosch@...lanox.com>
> ---
>  drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c |  2 +-
>  include/net/ipv6.h                                    | 11 +++++++++++
>  2 files changed, 12 insertions(+), 1 deletion(-)
> 

Acked-by: David Ahern <dsahern@...il.com>

For consistency, would be good to use that inline everywhere the sysctl
is referenced.