netdev - Re: [PATCH 3/4 net-next] ibmvnic: Pad small packets to minimum MTU size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <9dfa5d43-820d-c208-8919-7cdd94e657e6@linux.vnet.ibm.com>
Date:   Mon, 12 Mar 2018 10:24:53 -0500
From:   Thomas Falcon <tlfalcon@...ux.vnet.ibm.com>
To:     David Miller <davem@...emloft.net>
Cc:     netdev@...r.kernel.org, nfont@...ux.vnet.ibm.com,
        jallen@...ux.vnet.ibm.com
Subject: Re: [PATCH 3/4 net-next] ibmvnic: Pad small packets to minimum MTU
 size

On 03/11/2018 09:56 PM, David Miller wrote:
> From: Thomas Falcon <tlfalcon@...ux.vnet.ibm.com>
> Date: Fri,  9 Mar 2018 13:23:56 -0600
>
>> +	/* For some backing devices, mishandling of small packets
>> +	 * can result in a loss of connection or TX stall. Device
>> +	 * architects recommend that no packet should be smaller
>> +	 * than the minimum MTU value provided to the driver, so
>> +	 * pad any packets to that length
>> +	 */
>> +	if (skb->len < netdev->min_mtu) {
>> +		return skb_put_padto(skb, netdev->min_mtu);
>> +	}
> Please do not use curly braces for a single statement
> basic block.
>
> Thank you.
>
Oops, sorry about that. I'll fix that and resend.

Thanks.