netdev - Re: [PATCH net v4 0/2] rhashtable: Fix rhltable duplicates insertion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180311.224841.884484260613999903.davem@davemloft.net>
Date:   Sun, 11 Mar 2018 22:48:41 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     ogerlitz@...lanox.com
Cc:     paulb@...lanox.com, tgraf@...g.ch, herbert@...dor.apana.org.au,
        netdev@...r.kernel.org, kliteyn@...lanox.com, roid@...lanox.com,
        shahark@...lanox.com, markb@...lanox.com, jiri@...lanox.com,
        matanb@...lanox.com
Subject: Re: [PATCH net v4 0/2] rhashtable: Fix rhltable duplicates
 insertion

From: Or Gerlitz <ogerlitz@...lanox.com>
Date: Sun, 11 Mar 2018 11:16:44 +0200

> On 3/7/2018 6:23 PM, David Miller wrote:
>> From: Paul Blakey <paulb@...lanox.com>
>> Date: Wed,  7 Mar 2018 16:00:11 +0200
>> 
>>> On our mlx5 driver fs_core.c, we use the rhltable interface to store
>>> flow groups. We noticed that sometimes we get a warning that flow group isn't
>>> found at removal. This rare case was caused when a specific scenario happened,
>>> insertion of a flow group with a similar match criteria (a duplicate),
>>> but only where the flow group rhash_head was second (or not first)
>>> on the relevant rhashtable bucket list.
> 
>> I already applied v3, sorry.  But I did add Herbert's ACKs.
> 
> Hi Dave,
> 
> In mlx5 we use this facility since 4.14, can you please push to
> -stable of at least 4.14 if not earlier?

Ok, queued up.