netdev - Re: [PATCH] ipv6: Use ip6_multipath_hash_policy() in rt6_multipath

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <78208e98-d7da-d654-e57e-fcb583a62334@gmail.com>
Date:   Mon, 12 Mar 2018 11:11:45 -0700
From:   David Ahern <dsahern@...il.com>
To:     David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH] ipv6: Use ip6_multipath_hash_policy() in
 rt6_multipath_hash().

On 3/12/18 8:10 AM, David Miller wrote:
> 
> Make use of the new helper.
> 
> Suggested-by: David Ahern <dsahern@...il.com>
> Signed-off-by: David S. Miller <davem@...emloft.net>
> ---
>  net/ipv6/route.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/ipv6/route.c b/net/ipv6/route.c
> index f0ae58424c45..81711e3e2604 100644
> --- a/net/ipv6/route.c
> +++ b/net/ipv6/route.c
> @@ -1846,7 +1846,7 @@ u32 rt6_multipath_hash(const struct net *net, const struct flowi6 *fl6,
>  	struct flow_keys hash_keys;
>  	u32 mhash;
>  
> -	switch (net->ipv6.sysctl.multipath_hash_policy) {
> +	switch (ip6_multipath_hash_policy(net)) {
>  	case 0:
>  		memset(&hash_keys, 0, sizeof(hash_keys));
>  		hash_keys.control.addr_type = FLOW_DISSECTOR_KEY_IPV6_ADDRS;
> 

Thanks for taking care of that!