netdev - Re: [PATCH net v3] net: phy: Tell caller result of phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180312.103407.1746384495514020212.davem@davemloft.net>
Date:   Mon, 12 Mar 2018 10:34:07 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     brad.mouring@...com
Cc:     andrew@...n.ch, f.fainelli@...il.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, sergei.shtylyov@...entembedded.com
Subject: Re: [PATCH net v3] net: phy: Tell caller result of phy_change()

From: Brad Mouring <brad.mouring@...com>
Date: Thu, 8 Mar 2018 16:23:03 -0600

> In 664fcf123a30e (net: phy: Threaded interrupts allow some simplification)
> the phy_interrupt system was changed to use a traditional threaded
> interrupt scheme instead of a workqueue approach.
> 
> With this change, the phy status check moved into phy_change, which
> did not report back to the caller whether or not the interrupt was
> handled. This means that, in the case of a shared phy interrupt,
> only the first phydev's interrupt registers are checked (since
> phy_interrupt() would always return IRQ_HANDLED). This leads to
> interrupt storms when it is a secondary device that's actually the
> interrupt source.
> 
> Signed-off-by: Brad Mouring <brad.mouring@...com>

Applied and queued up for -stable, thanks.