lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 13 Mar 2018 08:49:18 -0500 From: Brad Mouring <brad.mouring@...com> To: Florian Fainelli <f.fainelli@...il.com> CC: Andrew Lunn <andrew@...n.ch>, Nicolas Ferre <nicolas.ferre@...rochip.com>, Rob Herring <robh+dt@...nel.org>, "David S . Miller" <davem@...emloft.net>, Michael Grzeschik <m.grzeschik@...gutronix.de>, Mark Rutland <mark.rutland@....com>, <netdev@...r.kernel.org>, Julia Cartwright <julia@...com>, <devicetree@...r.kernel.org> Subject: Re: [PATCH v4 net-next 3/4] net: macb: Add phy-handle DT support On Mon, Mar 12, 2018 at 03:30:53PM -0700, Florian Fainelli wrote: > On 03/12/2018 02:57 PM, Andrew Lunn wrote: > >> + /* attempt to find a phy-handle */ > >> + if (!(bp->phy_node = of_parse_phandle(np, "phy-handle", 0))) { > >> + > >> + /* fallback to standard phy registration if no phy were > >> + * found during dt phy registration > >> + */ > >> + if (!phy_find_first(bp->mii_bus)) { > >> + for (i = 0; i < PHY_MAX_ADDR; i++) { > >> + struct phy_device *phydev; > >> + > >> + phydev = mdiobus_scan(bp->mii_bus, i); > >> + if (IS_ERR(phydev) && > >> + PTR_ERR(phydev) != -ENODEV) { > >> + ret = PTR_ERR(phydev); > >> + break; > >> + } > > > > Hi Brad > > I would be a bit relaxed on these warnings because the existing function > indentation really makes it easy to be over 80 columns. Unless you have > a preliminary patch which, as I was suggesting earlier, re-arranges the > branches such that if (!np) is the first thing you test, I don't see how > this can look any better... I'll try to work this a bit more, thanks for the feedback and the patience. -- Brad
Powered by blists - more mailing lists