netdev - Re: [PATCH V2 net 1/1] net/smc: simplify wait when closing listen socket

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180313.111049.166541727870833774.davem@davemloft.net>
Date:   Tue, 13 Mar 2018 11:10:49 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     ubraun@...ux.vnet.ibm.com
Cc:     netdev@...r.kernel.org, linux-s390@...r.kernel.org,
        schwidefsky@...ibm.com, heiko.carstens@...ibm.com,
        raspl@...ux.vnet.ibm.com
Subject: Re: [PATCH V2 net 1/1] net/smc: simplify wait when closing listen
 socket

From: Ursula Braun <ubraun@...ux.vnet.ibm.com>
Date: Tue, 13 Mar 2018 10:41:54 +0100

> Closing of a listen socket wakes up kernel_accept() of
> smc_tcp_listen_worker(), and then has to wait till smc_tcp_listen_worker()
> gives up the internal clcsock. The wait logic introduced with
> commit 127f49705823 ("net/smc: release clcsock from tcp_listen_worker")
> might wait longer than necessary. This patch implements the idea to
> implement the wait just with flush_work(), and gets rid of the extra
> smc_close_wait_listen_clcsock() function.
> 
> Fixes: 127f49705823 ("net/smc: release clcsock from tcp_listen_worker")
> Reported-by: Hans Wippel <hwippel@...ux.vnet.ibm.com>
> Signed-off-by: Ursula Braun <ubraun@...ux.vnet.ibm.com>

This looks a lot better, applied, thank you.