netdev - Re: [PATCH 12/15] ice: Add stats and ethtool support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 13 Mar 2018 12:17:10 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     "Venkataramanan, Anirudh" <anirudh.venkataramanan@...el.com>,
        "kubakici@...pl" <kubakici@...pl>
Cc:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
Subject: Re: [PATCH 12/15] ice: Add stats and ethtool support



On 03/13/2018 12:05 PM, Venkataramanan, Anirudh wrote:
> On Fri, 2018-03-09 at 15:14 -0800, Jakub Kicinski wrote:
>> On Fri,  9 Mar 2018 09:21:33 -0800, Anirudh Venkataramanan wrote:
>>> +static const struct ice_stats ice_net_stats[] = {
>>> +	ICE_NETDEV_STAT(rx_packets),
>>> +	ICE_NETDEV_STAT(tx_packets),
>>> +	ICE_NETDEV_STAT(rx_bytes),
>>> +	ICE_NETDEV_STAT(tx_bytes),
>>> +	ICE_NETDEV_STAT(rx_errors),
>>> +	ICE_NETDEV_STAT(tx_errors),
>>> +	ICE_NETDEV_STAT(rx_dropped),
>>> +	ICE_NETDEV_STAT(tx_dropped),
>>> +	ICE_NETDEV_STAT(multicast),
>>> +	ICE_NETDEV_STAT(rx_length_errors),
>>> +	ICE_NETDEV_STAT(rx_crc_errors),
>>> +};
>>
>> Please don't duplicate standard netdev stats in ethtool -S.
> 
> Jacub,
> 
> Thanks for the feedback. I am not sure I understand what's being asked
> here. Do you mean to say that standard netdev stats should not be
> printed when we do ethtool -S or something else?
> 
> Thanks!
> Ani
> 

Yes, this is a recurring mistake

See commit
bf909456f6a89654cb65c01fe83a4f9b133bf978 Revert "net: hns3: Add packet 
statistics of netdev"