netdev - Re: [PATCH iproute2] Revert "iproute: "list/flush/save default" selected all of the routes"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3ebb9805-fb69-c67d-6222-c6d1d344f4ec@msu.ru>
Date:   Tue, 13 Mar 2018 21:12:45 +0100
From:   Alexander Zubkov <green@....ru>
To:     Luca Boccassi <bluca@...ian.org>,
        Stephen Hemminger <stephen@...workplumber.org>
Cc:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH iproute2] Revert "iproute: "list/flush/save default"
 selected all of the routes"

Hi,

I just realized that you need patch for v4.15.0, which is easier to do.
I'll send it as separate message now. I will make patch for the master 
branch, but later.

On 13.03.2018 13:02, Luca Boccassi wrote:
> On Tue, 2018-03-13 at 12:05 +0100, Alexander Zubkov wrote:
>> Hello again,
>>
>> The fun thing is that before the commit "ip route ls all" showed all
>> routes, but "ip -[4|6] route ls all" showed only default. So it was
>> broken too, but in other way.
>> I see parsing of prefix was changed since my patch. So I need several
>> days to propose fix. I think if "ip route ls [all|any]" shows all
>> routes and "ip route ls default" shows only default, everybody will
>> be happy with that?
> 
> Hi,
> 
> My only concern is that behaviour of existing commands that have been
> in releases is not changed, otherwise I get bugs raised :-)
> 
> Thank you for your work!
> 
>> 13.03.2018, 09:46, "Alexander Zubkov" <green@....ru>:
>>> Hello.
>>>
>>> May be the better way would be to change how "all"/"any" argument
>>> behaves? My original concern was about "default" only. I agree too,
>>> that "all" or "any" should work for all routes. But not for the
>>> default.
>>>
>>> 12.03.2018, 22:37, "Luca Boccassi" <bluca@...ian.org>:
>>>>   On Mon, 2018-03-12 at 14:03 -0700, Stephen Hemminger wrote:
>>>>>    This reverts commit 9135c4d6037ff9f1818507bac0049fc44db8c3d2.
>>>>>
>>>>>    Debian maintainer found that basic command:
>>>>>            # ip route flush all
>>>>>    No longer worked as expected which breaks user scripts and
>>>>>    expectations. It no longer flushed all IPv4 routes.
>>>>>
>>>>>    Reported-by: Luca Boccassi <bluca@...ian.org>
>>>>>    Signed-off-by: Stephen Hemminger <stephen@...workplumber.org>
>>>>>    ---
>>>>>     ip/iproute.c | 65 ++++++++++++++++++----------------------
>>>>> --------
>>>>>    ------------
>>>>>     lib/utils.c  | 13 ++++++++++++
>>>>>     2 files changed, 32 insertions(+), 46 deletions(-)
>>>>
>>>>   Tested-by: Luca Boccassi <bluca@...ian.org>
>>>>
>>>>   Thanks, solves the problem. I'll backport it to Debian.
>>>>
>>>>   Alexander, reproducing the issue is quite simple - before that
>>>> commit,
>>>>   ip route ls all showed all routes, but with the change it
>>>> started
>>>>   showing only the default table. Same for ip route flush.
>>>>
>>>>   --
>>>>   Kind regards,
>>>>   Luca Boccassi
>