lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 13 Mar 2018 05:51:13 +0000 From: Razvan Stefanescu <razvan.stefanescu@....com> To: Andrew Lunn <andrew@...n.ch> CC: "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>, "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, Alexander Graf <agraf@...e.de>, "arnd@...db.de" <arnd@...db.de>, Alexandru Marginean <alexandru.marginean@....com>, Ruxandra Ioana Ciocoi Radulescu <ruxandra.radulescu@....com>, Ioana Ciornei <ioana.ciornei@....com>, Laurentiu Tudor <laurentiu.tudor@....com>, "stuyoder@...il.com" <stuyoder@...il.com> Subject: RE: [PATCH v4 2/6] staging: fsl-dpaa2/ethsw: Add Freescale DPAA2 Ethernet Switch driver > -----Original Message----- > From: Andrew Lunn [mailto:andrew@...n.ch] > Sent: Monday, March 12, 2018 4:37 PM > To: Razvan Stefanescu <razvan.stefanescu@....com> > Cc: gregkh@...uxfoundation.org; devel@...verdev.osuosl.org; linux- > kernel@...r.kernel.org; netdev@...r.kernel.org; Alexander Graf > <agraf@...e.de>; arnd@...db.de; Alexandru Marginean > <alexandru.marginean@....com>; Ruxandra Ioana Ciocoi Radulescu > <ruxandra.radulescu@....com>; Ioana Ciornei <ioana.ciornei@....com>; > Laurentiu Tudor <laurentiu.tudor@....com>; stuyoder@...il.com > Subject: Re: [PATCH v4 2/6] staging: fsl-dpaa2/ethsw: Add Freescale DPAA2 > Ethernet Switch driver > > > +static int port_netdevice_event(struct notifier_block *unused, > > + unsigned long event, void *ptr) > > +{ > > + struct net_device *netdev = netdev_notifier_info_to_dev(ptr); > > + struct netdev_notifier_changeupper_info *info = ptr; > > + struct net_device *upper_dev; > > + int err = 0; > > + > > + if (netdev->netdev_ops != ðsw_port_ops) > > + return NOTIFY_DONE; > > + > > + /* Handle just upper dev link/unlink for the moment */ > > + if (event == NETDEV_CHANGEUPPER) { > > + upper_dev = info->upper_dev; > > + if (netif_is_bridge_master(upper_dev)) { > > + if (info->linking) > > + err = port_bridge_join(netdev); > > + else > > + err = port_bridge_leave(netdev); > > + } > > + } > > + > > + return notifier_from_errno(err); > > +} > > I could be missing something here, but don't you need to pass to > port_bridge_join() which bridge the port is joining. There can be > multiple bridges, so you need to ensure the port joins the correct > bridge. > Thank you for noticing this. I'll add proper checks in next version. Razvan > Andrew
Powered by blists - more mailing lists