netdev - Re: [PATCH net-next v2 0/4] ibmvnic: Fix VLAN and other device errata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180312.205927.730960247311710768.davem@davemloft.net>
Date:   Mon, 12 Mar 2018 20:59:27 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     tlfalcon@...ux.vnet.ibm.com
Cc:     netdev@...r.kernel.org, jallen@...ux.vnet.ibm.com,
        nfont@...ux.vnet.ibm.com
Subject: Re: [PATCH net-next v2 0/4] ibmvnic: Fix VLAN and other device
 errata

From: Thomas Falcon <tlfalcon@...ux.vnet.ibm.com>
Date: Mon, 12 Mar 2018 17:07:38 -0500

> On 03/12/2018 11:56 AM, David Miller wrote:
>> From: Thomas Falcon <tlfalcon@...ux.vnet.ibm.com>
>> Date: Mon, 12 Mar 2018 11:51:01 -0500
>>
>>> This patch series contains fixes for VLAN and other backing hardware
>>> errata. The VLAN fixes are mostly to account for the additional four
>>> bytes VLAN header in TX descriptors and buffers, when applicable.
>>>
>>> The other fixes for device errata are to pad small packets to avoid a
>>> possible connection error that can occur when some devices attempt to
>>> transmit small packets. The other fixes are GSO related. Some devices
>>> cannot handle a smaller MSS or a packet with a single segment, so
>>> disable GSO in those cases.
>>>
>>> v2: Fix style mistake (unneeded brackets) in patch 3/4
>> Series applied, thanks Thomas.
>>
> Really sorry about this, but 3/4 is still wrong.  There is actually a compiler warning caused by it, which I'm surprised wasn't caught by the test robot.  Is there still time to send a v3?

If it's in my tree you must send a fixup patch.