netdev - Re: [2/2] net/usb/ax88179_178a: Delete three unnecessary variables in ax88179_chk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7d45bd0c-5ab2-a2c0-d746-ef2d859eea08@users.sourceforge.net>
Date:   Tue, 13 Mar 2018 08:24:31 +0100
From:   SF Markus Elfring <elfring@...rs.sourceforge.net>
To:     Oliver Neukum <oneukum@...e.com>, linux-usb@...r.kernel.org,
        netdev@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>,
        "Andrew F. Davis" <afd@...com>, Andrew Lunn <andrew@...n.ch>,
        Bjørn Mork <bjorn@...k.no>,
        "David S. Miller" <davem@...emloft.net>,
        Philippe Reynes <tremyfr@...il.com>,
        Yuval Shaia <yuval.shaia@...cle.com>
Subject: Re: [2/2] net/usb/ax88179_178a: Delete three unnecessary variables in
 ax88179_chk_eee()

>> Use three values directly for a condition check without assigning them
>> to intermediate variables.
> 
> Hi,
> 
> what is the benefit of this?

I proposed a small source code reduction.

Other software design directions might become more interesting for this use case.

Regards,
Markus