netdev - Re: [Intel-wired-lan] [PATCH 12/15] ice: Add stats and ethtool support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180314081317.1bbfe856@xeon-e3>
Date:   Wed, 14 Mar 2018 08:13:17 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Jesse Brandeburg <jesse.brandeburg@...el.com>
Cc:     Eric Dumazet <eric.dumazet@...il.com>, davem@...emloft.net,
        "Venkataramanan, Anirudh" <anirudh.venkataramanan@...el.com>,
        "kubakici@...pl" <kubakici@...pl>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
Subject: Re: [Intel-wired-lan] [PATCH 12/15] ice: Add stats and ethtool
 support

On Tue, 13 Mar 2018 14:14:14 -0700
Jesse Brandeburg <jesse.brandeburg@...el.com> wrote:

> Maybe it's just that I've been doing this too long, but I regularly
> (and many other customers/users do as well) depend on the ethtool stats
> being atomically updated w.r.t. each other.  This means that if I'm
> getting the over rx_packets, as well as the per-queue rx_packets, and I
> read them all at once from the driver with ethtool, then I can check
> that things are working as expected.

Any application depending on this behavior is really fragile.
It is unportable to other devices (which I guess is to Intel's benefit)
and relying on guarantees not provided by current Linux network devices.