netdev - Re: [PATCH net] net: use skb_to_full_sk() in skb_update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180314.125540.1017160062116866565.davem@davemloft.net>
Date:   Wed, 14 Mar 2018 12:55:40 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     edumazet@...gle.com
Cc:     netdev@...r.kernel.org, avagin@...tuozzo.com,
        eric.dumazet@...il.com
Subject: Re: [PATCH net] net: use skb_to_full_sk() in skb_update_prio()

From: Eric Dumazet <edumazet@...gle.com>
Date: Wed, 14 Mar 2018 09:04:16 -0700

> Andrei Vagin reported a KASAN: slab-out-of-bounds error in
> skb_update_prio()
> 
> Since SYNACK might be attached to a request socket, we need to
> get back to the listener socket.
> Since this listener is manipulated without locks, add const
> qualifiers to sock_cgroup_prioidx() so that the const can also
> be used in skb_update_prio()
> 
> Also add the const qualifier to sock_cgroup_classid() for consistency.
> 
> Fixes: ca6fb0651883 ("tcp: attach SYNACK messages to request sockets instead of listener")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: Andrei Vagin <avagin@...tuozzo.com>

Applied and queued up for -stable, thanks!