netdev - Re: [PATCH iproute2 1/1] tc: use get_u32() in psample action to match types

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 14 Mar 2018 07:41:28 +0200
From:   yotam gigi <yotam.gi@...il.com>
To:     Roman Mashak <mrv@...atatu.com>
Cc:     stephen@...workplumber.org, netdev@...r.kernel.org,
        kernel@...atatu.com, Jamal Hadi Salim <jhs@...atatu.com>,
        xiyou.wangcong@...il.com, jiri@...nulli.us
Subject: Re: [PATCH iproute2 1/1] tc: use get_u32() in psample action to match types

On Tue, Mar 13, 2018 at 11:16 PM, Roman Mashak <mrv@...atatu.com> wrote:

Makes sense :)

Acked-by: Yotam Gigi <yotam.gi@...il.com>

> Signed-off-by: Roman Mashak <mrv@...atatu.com>
> ---
>  tc/m_sample.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tc/m_sample.c b/tc/m_sample.c
> index ff5ee6bd1ef6..dff986f59999 100644
> --- a/tc/m_sample.c
> +++ b/tc/m_sample.c
> @@ -65,7 +65,7 @@ static int parse_sample(struct action_util *a, int *argc_p, char ***argv_p,
>         while (argc > 0) {
>                 if (matches(*argv, "rate") == 0) {
>                         NEXT_ARG();
> -                       if (get_unsigned(&rate, *argv, 10) != 0) {
> +                       if (get_u32(&rate, *argv, 10) != 0) {
>                                 fprintf(stderr, "Illegal rate %s\n", *argv);
>                                 usage();
>                                 return -1;
> @@ -73,7 +73,7 @@ static int parse_sample(struct action_util *a, int *argc_p, char ***argv_p,
>                         rate_set = true;
>                 } else if (matches(*argv, "group") == 0) {
>                         NEXT_ARG();
> -                       if (get_unsigned(&group, *argv, 10) != 0) {
> +                       if (get_u32(&group, *argv, 10) != 0) {
>                                 fprintf(stderr, "Illegal group num %s\n",
>                                         *argv);
>                                 usage();
> @@ -82,7 +82,7 @@ static int parse_sample(struct action_util *a, int *argc_p, char ***argv_p,
>                         group_set = true;
>                 } else if (matches(*argv, "trunc") == 0) {
>                         NEXT_ARG();
> -                       if (get_unsigned(&trunc, *argv, 10) != 0) {
> +                       if (get_u32(&trunc, *argv, 10) != 0) {
>                                 fprintf(stderr, "Illegal truncation size %s\n",
>                                         *argv);
>                                 usage();
> --
> 2.7.4
>