netdev - Re: [PATCH net] net: sched: fix uses after free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANn89iKQAp2R4h6RSOz9UwVyQAKt9DZ14KHC3bB+d_=o_O896Q@mail.gmail.com>
Date:   Thu, 15 Mar 2018 01:54:21 +0000
From:   Eric Dumazet <edumazet@...gle.com>
To:     David Miller <davem@...emloft.net>
Cc:     netdev <netdev@...r.kernel.org>,
        Eric Dumazet <eric.dumazet@...il.com>,
        John Fastabend <john.fastabend@...il.com>,
        Jamal Hadi Salim <jhs@...atatu.com>
Subject: Re: [PATCH net] net: sched: fix uses after free

On Wed, Mar 14, 2018 at 6:48 PM Eric Dumazet <edumazet@...gle.com> wrote:

> syzbot reported one use-after-free in pfifo_fast_enqueue() [1]

> Issue here is that we can not reuse skb after a successful
skb_array_produce()
> since another cpu might have consumed it already.

> I believe a similar problem exists in try_bulk_dequeue_skb_slow()
> in case we put an skb into qdisc_enqueue_skb_bad_txq() for lockless qdisc.

> [1]
> ==================================================================


I sent a V2 without  this ====== line that is fooling patchwork, sorry for
the noise.