lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20180315165247.165ac10e@xeon-e3>
Date:   Thu, 15 Mar 2018 16:52:47 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Anirudh Venkataramanan <anirudh.venkataramanan@...el.com>
Cc:     intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org,
        Andrew Lunn <andrew@...n.ch>, Jakub Kicinski <kubakici@...pl>
Subject: Re: [PATCH v2 12/15] ice: Add stats and ethtool support

On Thu, 15 Mar 2018 16:47:59 -0700
Anirudh Venkataramanan <anirudh.venkataramanan@...el.com> wrote:

> +
> +static const struct ice_stats ice_gstrings_vsi_stats[] = {
> +	ICE_VSI_STAT("tx_unicast", eth_stats.tx_unicast),
> +	ICE_VSI_STAT("rx_unicast", eth_stats.rx_unicast),
> +	ICE_VSI_STAT("tx_multicast", eth_stats.tx_multicast),
> +	ICE_VSI_STAT("rx_multicast", eth_stats.rx_multicast),
> +	ICE_VSI_STAT("tx_broadcast", eth_stats.tx_broadcast),
> +	ICE_VSI_STAT("rx_broadcast", eth_stats.rx_broadcast),
> +	ICE_VSI_STAT("tx_bytes", eth_stats.tx_bytes),
> +	ICE_VSI_STAT("rx_bytes", eth_stats.rx_bytes),
> +	ICE_VSI_STAT("rx_discards", eth_stats.rx_discards),
> +	ICE_VSI_STAT("tx_errors", eth_stats.tx_errors),
> +	ICE_VSI_STAT("tx_linearize", tx_linearize),
> +	ICE_VSI_STAT("rx_unknown_protocol", eth_stats.rx_unknown_protocol),
> +	ICE_VSI_STAT("rx_alloc_fail", rx_buf_failed),
> +	ICE_VSI_STAT("rx_pg_alloc_fail", rx_page_failed),
> +};
> +

Ignoring feedback from maintainers is unlikely to help get your driver adopted.

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ