[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20180316130125.C69D860C4F@smtp.codeaurora.org>
Date: Fri, 16 Mar 2018 13:01:25 +0000 (UTC)
From: Kalle Valo <kvalo@...eaurora.org>
To: Rafał Miłecki <zajec5@...il.com>
Cc: Arend van Spriel <arend.vanspriel@...adcom.com>,
Franky Lin <franky.lin@...adcom.com>,
Hante Meuleman <hante.meuleman@...adcom.com>,
Chi-Hsien Lin <chi-hsien.lin@...ress.com>,
Wright Feng <wright.feng@...ress.com>,
Pieter-Paul Giesberts <pieter-paul.giesberts@...adcom.com>,
James Hughes <james.hughes@...pberrypi.org>,
linux-wireless@...r.kernel.org,
brcm80211-dev-list.pdl@...adcom.com,
brcm80211-dev-list@...ress.com, netdev@...r.kernel.org,
Linus Lüssing <linus.luessing@...3.blue>,
Felix Fietkau <nbd@....name>,
bridge@...ts.linux-foundation.org,
Rafał Miłecki <rafal@...ecki.pl>
Subject: Re: [V2] brcmfmac: drop Inter-Access Point Protocol packets by default
Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@...ecki.pl>
>
> Testing brcmfmac with more recent firmwares resulted in AP interfaces
> not working in some specific setups. Debugging resulted in discovering
> support for IAPP in Broadcom's firmwares.
>
> Older firmwares were only generating 802.11f frames. Newer ones like:
> 1) 10.10 (TOB) (r663589)
> 2) 10.10.122.20 (r683106)
> for 4366b1 and 4366c0 respectively seem to also /respect/ 802.11f frames
> in the Tx path by performing a STA disassociation.
>
> This obsoleted standard and its implementation is something that:
> 1) Most people don't need / want to use
> 2) Can allow local DoS attacks
> 3) Breaks AP interfaces in some specific bridge setups
>
> To solve issues it can cause this commit modifies brcmfmac to drop IAPP
> packets. If affects:
> 1) Rx path: driver won't be sending these unwanted packets up.
> 2) Tx path: driver will reject packets that would trigger STA
> disassociation perfromed by a firmware (possible local DoS attack).
>
> It appears there are some Broadcom's clients/users who care about this
> feature despite the drawbacks. They can switch it on using a new module
> param.
>
> This change results in only two more comparisons (check for module param
> and check for Ethernet packet length) for 99.9% of packets. Its overhead
> should be very minimal.
>
> Signed-off-by: Rafał Miłecki <rafal@...ecki.pl>
> Acked-by: Arend van Spriel <arend.vanspriel@...adcom.com>
Patch applied to wireless-drivers.git, thanks.
125905517028 brcmfmac: drop Inter-Access Point Protocol packets by default
--
https://patchwork.kernel.org/patch/10283971/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Powered by blists - more mailing lists