netdev - Re: [PATCH net 1/2] vmxnet3: avoid xmit reset due to a race in vmxnet3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180316.105339.409351441331109496.davem@redhat.com>
Date:   Fri, 16 Mar 2018 10:53:39 -0400 (EDT)
From:   David Miller <davem@...hat.com>
To:     doshir@...are.com
Cc:     netdev@...r.kernel.org, ntanaka@...are.com, skhare@...are.com,
        pv-drivers@...are.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net 1/2] vmxnet3: avoid xmit reset due to a race in
 vmxnet3

From: Ronak Doshi <doshir@...are.com>
Date: Tue, 13 Mar 2018 12:40:08 -0700

> @@ -977,6 +977,8 @@ vmxnet3_tq_xmit(struct sk_buff *skb, struct vmxnet3_tx_queue *tq,
>  {
>  	int ret;
>  	u32 count;
> +	int numPkts;
> +	int localTxNumDeferred;
>  	unsigned long flags;
>  	struct vmxnet3_tx_ctx ctx;
>  	union Vmxnet3_GenericDesc *gdesc;

Please use local variable names with all lowercase letters.