netdev - Re: DTS for our Configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20180316151206.GG17895@lunn.ch>
Date:   Fri, 16 Mar 2018 16:12:06 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Dror Alon <adror@....co.il>
Cc:     "'netdev@...r.kernel.org'" <netdev@...r.kernel.org>,
        Efter Yoram <yefter@....co.il>,
        Alayev Michael <malayev@....co.il>
Subject: Re: DTS for our Configuration

On Thu, Mar 15, 2018 at 02:00:00PM +0000, Dror Alon wrote:
> Hello Andrew,
> Thanks for your fast responses.
> Michael and I keep trying to configure our linux Zynq7000 board.
> We can't succeed with configure our SWITCHES via the DTS file.

> Please. See the next diagram, and please Do you have any DTS Sample
> for this Setup ?

Hi Dror

I'm surprised you are doing SGMII between ports 10. They are 10G
capable.

gem0: {
	fixed-link {
		speed = <1000>;
		full-duplex;
	};

	phy0: phy@0: {
		reg = <0>;
	};

	switch0: switch@1c: {
		compatible = "marvell,mv88e6190";
		reg = <0x1c>;

		ports {
			#address-cells = <1>;
			#size-cells = <0>;

			port@0 {
				reg = <0>;
				label = "cpu";
				fixed-link {
					speed = <1000>;
					full-duplex;
				};
			port@1 {
				reg = <1>;
				label = "lan0";
			};
			port@2 {
				reg = <2>;
				label = "lan1";
			};
			...
			switch0port10: port@10 {
				reg = <10>;
				label = "dsa";
				link = <&switch1port10>;
				phy-mode = "sgmii";
			 	fixed-link {
					speed = <1000>;
					full-duplex;
				};
			};
		};
	};

	switch1: switch@1d: {
		compatible = "marvell,mv88e6190";
		reg = <0x1d>;

		ports {
			#address-cells = <1>;
			#size-cells = <0>;

			port@0 {
				reg = <0>;
				label = "lan9";
				};
			port@1 {
				reg = <1>;
				label = "lan10";
			};
			port@2 {
				reg = <2>;
				label = "lan11";
			};
			...
			switch1port10: port@10 {
				reg = <10>;
				label = "dsa";
				link = <&switch0port10>;
				phy-mode = "sgmii";
			 	fixed-link {
					speed = <1000>;
					full-duplex;
				};
			};
		};
	};
};

gem1: {
      phy-handle = <phy0>;
};

It looks like you have at last one issue to solve in the macb driver.
If you have a fixed-phy, it does an mdiobus_register. This means it is
going to ignore all the other device tree properties. You need it to
do an of_mdiobus_register().

   Andrew