netdev - Re: [PATCH v2 03/15] ice: Start hardware initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e39c8a7c-a6ad-3414-fec9-31540b65b010@oracle.com>
Date:   Fri, 16 Mar 2018 09:21:16 -0700
From:   Shannon Nelson <shannon.nelson@...cle.com>
To:     Anirudh Venkataramanan <anirudh.venkataramanan@...el.com>,
        intel-wired-lan@...ts.osuosl.org
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH v2 03/15] ice: Start hardware initialization

On 3/15/2018 4:47 PM, Anirudh Venkataramanan wrote:
> This patch implements multiple pieces of the initialization flow
> as follows:
> 
> 1) A reset is issued to ensure a clean device state, followed
>     by initialization of admin queue interface.
> 
> 2) Once the admin queue interface is up, clear the PF config
>     and transition the device to non-PXE mode.
> 
> 3) Get the NVM configuration stored in the device's non-volatile
>     memory (NVM) using ice_init_nvm.
> 
> CC: Shannon Nelson <shannon.nelson@...cle.com>
> Signed-off-by: Anirudh Venkataramanan <anirudh.venkataramanan@...el.com>
> ---
> v2: Addressed Shannon Nelson's review comments by
>      1) removing an unnecessary register write in ice_aq_clear_pxe_mode.
>      2) adding a comment explaining the need to convert word sized values
>         to byte sized values.

These two changes look fine.

sln

Acked-by: Shannon Nelson <shannon.nelson@...cle.com>