netdev - Re: [PATCH net-next v3 4/4] net: qualcomm: rmnet: Implement fill

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180316.123016.389614962376533370.davem@davemloft.net>
Date:   Fri, 16 Mar 2018 12:30:16 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     subashab@...eaurora.org
Cc:     joe@...ches.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v3 4/4] net: qualcomm: rmnet: Implement
 fill_info

From: Subash Abhinov Kasiviswanathan <subashab@...eaurora.org>
Date: Wed, 14 Mar 2018 13:01:04 -0600

> +	if (nla_put_u16(skb, IFLA_VLAN_ID, priv->mux_id))
> +		goto nla_put_failure;
> +
> +	port = rmnet_get_port_rtnl(real_dev);
> +
> +	f.flags = port->data_format;
> +	f.mask  = ~0;
> +
> +	if (nla_put(skb, IFLA_VLAN_FLAGS, sizeof(f), &f))
> +		goto nla_put_failure;

Please don't use VLAN netlink attributes to report rmnet device
specific values.

Instead, please add appropriate new netlink attributes which
clearly show that they are the rmnet mux_id and flags.  You'll
also need to provide UAPI definitions for these flag bits
to go along with the attribute name.

Thanks.