netdev - Re: [PATCH net] skbuff: Fix not waking applications when errors are enqueued

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180316.123724.729271943170129684.davem@davemloft.net>
Date:   Fri, 16 Mar 2018 12:37:24 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     vinicius.gomes@...el.com
Cc:     netdev@...r.kernel.org, randy.e.witt@...el.com,
        eric.dumazet@...il.com
Subject: Re: [PATCH net] skbuff: Fix not waking applications when errors
 are enqueued

From: Vinicius Costa Gomes <vinicius.gomes@...el.com>
Date: Wed, 14 Mar 2018 13:32:09 -0700

> When errors are enqueued to the error queue via sock_queue_err_skb()
> function, it is possible that the waiting application is not notified.
> 
> Calling 'sk->sk_data_ready()' would not notify applications that
> selected only POLLERR events in poll() (for example).
> 
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Reported-by: Randy E. Witt <randy.e.witt@...el.com>
> Reviewed-by: Eric Dumazet <edumazet@...gle.com>
> Signed-off-by: Vinicius Costa Gomes <vinicius.gomes@...el.com>

Applied and queued up for -stable, thank you.

Since this is going into 'net', it doesn't need to be in your net-next
submission as 'net' changes will (eventually) propagate into net-next.

Please fix that up, thank you.