netdev - Re: [PATCH net-next 1/2] net/ipv6: Handle onlink flag with multipath routes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <36fe3314-1c44-5516-54c5-4aa33e80942c@gmail.com>
Date:   Fri, 16 Mar 2018 11:18:55 -0700
From:   David Ahern <dsahern@...il.com>
To:     David Miller <davem@...emloft.net>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net-next 1/2] net/ipv6: Handle onlink flag with multipath
 routes

On 3/16/18 9:38 AM, David Miller wrote:
> From: David Ahern <dsahern@...il.com>
> Date: Fri, 16 Mar 2018 08:45:10 -0700
> 
>> On 3/16/18 8:40 AM, David Miller wrote:
>>> Hmmm, this actually "accumulates" the flag rather than sets it.
>>>
>>> Have you thought about what should happen if the cfg has RTNH_F_ONLINK
>>> set?
>>
>> yes, that's why the test script adds cases with the ONLINK flag set for
>> both nexthops, then one with it on the first nexthop only, and one with
>> the flag only on the second nexthop.
>>
>> If you look at the full loop 'cfg' is the variable with the user data,
>> and r_cfg is the 'local loop version' so r_cfg.fc_flags gets reset for
>> each nexthop:
>>
>>         while (rtnh_ok(rtnh, remaining)) {
>>                 memcpy(&r_cfg, cfg, sizeof(*cfg));
>> 		...
>> 		r_cfg.fc_flags |= (rtnh->rtnh_flags & RTNH_F_ONLINK);
>> 		rt = ip6_route_info_create(&r_cfg, extack);
> 
> Right.
> 
>>> I think you should either change this logic to a true 'set', or adjust
>>> your commit message to address this aspect of the new behavior.
>>
>> I can update the commit message.
> 
> Please do, thanks David.
> 

And it looks like patch 1 needs to be in 'net'; did not realize the ipv6
ONLINK support is already in 4.16. I will send the patch adding tests
separately for net-next.