netdev - Re: [PATCH net 1/7] net: aquantia: Fix hardware reset when SPI may rarely hangup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 16 Mar 2018 14:50:45 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     igor.russkikh@...antia.com
Cc:     netdev@...r.kernel.org, darcari@...hat.com,
        pavel.belous@...antia.com
Subject: Re: [PATCH net 1/7] net: aquantia: Fix hardware reset when SPI may
 rarely hangup

From: Igor Russkikh <igor.russkikh@...antia.com>
Date: Fri, 16 Mar 2018 13:53:44 +0300

> diff --git a/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils.c b/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils.c
> index 967f0fd..0da480b 100644
> --- a/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils.c
> +++ b/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils.c
> @@ -80,15 +80,14 @@ int hw_atl_utils_initfw(struct aq_hw_s *self, const struct aq_fw_ops **fw_ops)
>  static int hw_atl_utils_soft_reset_flb(struct aq_hw_s *self)
>  {
>  	int k = 0;
> -	u32 gsr;
> +	u32 gsr, val;

Please preserve the reverse christmas tree ordering (longest to shortest line) for
variable declarations here.