netdev - [PATCH RFC 2/2] sched: pass extack through even if skip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <300158ea936857419218a1cbab788dc72ccf349a.1521226621.git.marcelo.leitner@gmail.com>
Date:   Fri, 16 Mar 2018 16:23:11 -0300
From:   Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
To:     netdev@...r.kernel.org
Cc:     marcelo.leitner@...il.com, Alexander Aring <aring@...atatu.com>,
        Jiri Pirko <jiri@...nulli.us>, Jakub Kicinski <kubakici@...pl>
Subject: [PATCH RFC 2/2] sched: pass extack through even if skip_sw is not set

Currently, when the rule is not to be exclusively executed by the
hardware, extack is not passed along. The idea was that hardware
failures are okay because the rule will get executed in software then.

This is not helpful in case one needs to understand why a certain rule
failed to get offloaded. Considering it may have been a temporary
failure, like resources exceeded or so, reproducing it later and knowing
it is triggering the same reason may be challenging.

This patch thus removes the condition and makes it always pass extack
structure along.

Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
---
 include/net/pkt_cls.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/include/net/pkt_cls.h b/include/net/pkt_cls.h
index e828d31be5dae0ae8c69016dfde50379296484aa..7cec393bb47974b48a6d510b8aa84534a7a98594 100644
--- a/include/net/pkt_cls.h
+++ b/include/net/pkt_cls.h
@@ -705,8 +705,7 @@ tc_cls_common_offload_init(struct tc_cls_common_offload *cls_common,
 	cls_common->chain_index = tp->chain->index;
 	cls_common->protocol = tp->protocol;
 	cls_common->prio = tp->prio;
-	if (tc_skip_sw(flags))
-		cls_common->extack = extack;
+	cls_common->extack = extack;
 }

 enum tc_fl_command {
-- 
2.14.3