netdev - Re: sctp: use proc_remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180316233307.GK30522@ZenIV.linux.org.uk>
Date:   Fri, 16 Mar 2018 23:33:07 +0000
From:   Al Viro <viro@...IV.linux.org.uk>
To:     David Miller <davem@...emloft.net>
Cc:     netdev@...r.kernel.org, linux-sctp@...r.kernel.org
Subject: Re: sctp: use proc_remove_subtree()

On Fri, Mar 16, 2018 at 12:44:15PM -0400, David Miller wrote:
> From: Al Viro <viro@...IV.linux.org.uk>
> Date: Wed, 14 Mar 2018 20:51:19 +0000
> 
> > On Wed, Mar 14, 2018 at 08:46:21PM +0000, Al Viro wrote:
> >> use proc_remove_subtree() for subtree removal, both on setup failure
> >> halfway through and on teardown.  No need to make simple things
> >> complex...
> > 
> > ... and sctp_dbg_objcnt_exit() can be removed as well - remove_proc_subtree()
> > will get that sucker automatically.  Either a trivial addition, or equally
> > trivial followup...
> 
> Please add it to this patch and resubmit.

Done...