netdev - Re: [PATCH v2] netns: send uevent messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 17 Mar 2018 11:29:03 +0100
From:   Christian Brauner <christian.brauner@...onical.com>
To:     David Miller <davem@...emloft.net>
Cc:     christian.brauner@...ntu.com, ebiederm@...ssion.com,
        gregkh@...uxfoundation.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, serge@...lyn.com,
        avagin@...tuozzo.com, ktkhai@...tuozzo.com
Subject: Re: [PATCH v2] netns: send uevent messages

On Fri, Mar 16, 2018 at 02:41:45PM -0400, David Miller wrote:
> From: Christian Brauner <christian.brauner@...ntu.com>
> Date: Fri, 16 Mar 2018 13:50:30 +0100
> 
> > +static int uevent_net_broadcast(struct sock *usk, struct sk_buff *skb,
> > +				struct netlink_ext_ack *extack)
> > +{
> > +	int ret;
> > +	/* u64 to chars: 2^64 - 1 = 21 chars */
> > +	char buf[sizeof("SEQNUM=") + 21];
> > +	struct sk_buff *skbc;
> 
> I hate to be difficult, but please use reverse christmas tree ordering
> for local variables.

No problem David, coding style is important. I'm about to send out
another version with:

/* u64 to chars: 2^64 - 1 = 21 chars */
char buf[sizeof("SEQNUM=") + 21];
struct sk_buff *skbc;
int ret;

Thanks!
Christian

> 
> > +static int uevent_net_rcv_skb(struct sk_buff *skb, struct nlmsghdr *nlh,
> > +			      struct netlink_ext_ack *extack)
> > +{
> > +	int ret;
> > +	struct net *net;
> 
> Likewise.
> 
> Thank you.