netdev - Re: [PATCH net-next] liquidio: Allow RX descriptors to be consumed before disabling NAPI.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 17 Mar 2018 17:01:40 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     felix.manlunas@...ium.com
Cc:     netdev@...r.kernel.org, raghu.vatsavayi@...ium.com,
        derek.chickles@...ium.com, satananda.burla@...ium.com
Subject: Re: [PATCH net-next] liquidio: Allow RX descriptors to be consumed
 before disabling NAPI.

From: Felix Manlunas <felix.manlunas@...ium.com>
Date: Wed, 14 Mar 2018 16:17:47 -0700

> From: Raghu Vatsavayi <raghu.vatsavayi@...ium.com>
> 
> Signed-off-by: Raghu Vatsavayi <raghu.vatsavayi@...ium.com>
> Acked-by: Derek Chickles <derek.chickles@...ium.com>
> Signed-off-by: Felix Manlunas <felix.manlunas@...ium.com>

This must have a reasonable commit message added, and that commit
message must explain in detail what exactly is happening here.

But since I did read the patch I do not think that doing a looping
sleeping read is the way to fix this problem.

Instead, you should find some way to wait on the specific event that
needs to occur.