netdev - Re: [PATCH net] mlxsw: spectrum_buffers: Set a minimum quota for CPU port traffic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180317.173531.1834206467235514432.davem@davemloft.net>
Date:   Sat, 17 Mar 2018 17:35:31 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     idosch@...lanox.com
Cc:     netdev@...r.kernel.org, jiri@...lanox.com, eddies@...lanox.com,
        alexpe@...lanox.com, mlxsw@...lanox.com
Subject: Re: [PATCH net] mlxsw: spectrum_buffers: Set a minimum quota for
 CPU port traffic

From: Ido Schimmel <idosch@...lanox.com>
Date: Thu, 15 Mar 2018 14:49:56 +0200

> In commit 9ffcc3725f09 ("mlxsw: spectrum: Allow packets to be trapped
> from any PG") I fixed a problem where packets could not be trapped to
> the CPU due to exceeded shared buffer quotas. The mentioned commit
> explains the problem in detail.
> 
> The problem was fixed by assigning a minimum quota for the CPU port and
> the traffic class used for scheduling traffic to the CPU.
> 
> However, commit 117b0dad2d54 ("mlxsw: Create a different trap group list
> for each device") assigned different traffic classes to different
> packet types and rendered the fix useless.
> 
> Fix the problem by assigning a minimum quota for the CPU port and all
> the traffic classes that are currently in use.
> 
> Fixes: 117b0dad2d54 ("mlxsw: Create a different trap group list for each device")
> Signed-off-by: Ido Schimmel <idosch@...lanox.com>
> Reported-by: Eddie Shklaer <eddies@...lanox.com>
> Tested-by: Eddie Shklaer <eddies@...lanox.com>
> Acked-by: Jiri Pirko <jiri@...lanox.com>
> ---
> Please consider the patch for -stable. Thanks!

Applied and queued up for -stable, thank you.