netdev - Re: [PATCH v2 net 1/2] vmxnet3: avoid xmit reset due to a race in vmxnet3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180317.200506.1922029560822089854.davem@davemloft.net>
Date:   Sat, 17 Mar 2018 20:05:06 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     doshir@...are.com
Cc:     netdev@...r.kernel.org, ntanaka@...are.com, skhare@...are.com,
        pv-drivers@...are.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 net 1/2] vmxnet3: avoid xmit reset due to a race in
 vmxnet3

From: Ronak Doshi <doshir@...are.com>
Date: Fri, 16 Mar 2018 14:47:54 -0700

> The field txNumDeferred is used by the driver to keep track of the number
> of packets it has pushed to the emulation. The driver increments it on
> pushing the packet to the emulation and the emulation resets it to 0 at
> the end of the transmit.
> 
> There is a possibility of a race either when (a) ESX is under heavy load or
> (b) workload inside VM is of low packet rate.
> 
> This race results in xmit hangs when network coalescing is disabled. This
> change creates a local copy of txNumDeferred and uses it to perform ring
> arithmetic.
> 
> Reported-by: Noriho Tanaka <ntanaka@...are.com>
> Signed-off-by: Ronak Doshi <doshir@...are.com>
> Acked-by: Shrikrishna Khare <skhare@...are.com>

Applied.