netdev - Re: [PATCH net-next v5 0/8] ibmvnic: Update TX pool and TX routines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180317.201256.1800347985414390416.davem@davemloft.net>
Date:   Sat, 17 Mar 2018 20:12:56 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     tlfalcon@...ux.vnet.ibm.com
Cc:     netdev@...r.kernel.org, jallen@...ux.vnet.ibm.com,
        nfont@...ux.vnet.ibm.com
Subject: Re: [PATCH net-next v5 0/8] ibmvnic: Update TX pool and TX routines

From: Thomas Falcon <tlfalcon@...ux.vnet.ibm.com>
Date: Fri, 16 Mar 2018 20:00:23 -0500

> This patch restructures the TX pool data structure and provides a
> separate TX pool array for TSO transmissions. This is already used
> in some way due to our unique DMA situation, namely that we cannot
> use single DMA mappings for packet data. Previously, both buffer
> arrays used the same pool entry. This restructuring allows for
> some additional cleanup in the driver code, especially in some
> places in the device transmit routine.
> 
> In addition, it allows us to more easily track the consumer
> and producer indexes of a particular pool. This has been
> further improved by better tracking of in-use buffers to
> prevent possible data corruption in case an invalid buffer
> entry is used.
> 
> v5: Fix bisectability mistake in the first patch. Removed
>     TSO-specific data in a later patch when it is no longer used.
> 
> v4: Fix error in 7th patch that causes an oops by using
>     the older fixed value for number of buffers instead
>     of the respective field in the tx pool data structure
> 
> v3: Forgot to update TX pool cleaning function to handle new data
>     structures. Included 7th patch for that.
> 
> v2: Fix typo in 3/6 commit subject line

Series applied, thanks Thomas.