netdev - Re: [PATCH net 4/7] net: aquantia: Add aq_tx_clean

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180319.093657.276061255844405174.davem@davemloft.net>
Date:   Mon, 19 Mar 2018 09:36:57 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     igor.russkikh@...antia.com
Cc:     netdev@...r.kernel.org, darcari@...hat.com,
        pavel.belous@...antia.com
Subject: Re: [PATCH net 4/7] net: aquantia: Add aq_tx_clean_budget and
 valid budget handling logic

From: Igor Russkikh <igor.russkikh@...antia.com>
Date: Mon, 19 Mar 2018 14:18:55 +0300

> 
> Hi David,
> 
> Thanks for the comments.
> 
>>>  
>>> +unsigned aq_tx_clean_budget = 256;
>>> +module_param_named(aq_tx_clean_budget, aq_tx_clean_budget, uint, 0644);
>>> +MODULE_PARM_DESC(aq_tx_clean_budget, "Maximum descriptors to cleanup on TX at once");
>>> +
>>>  static void aq_nic_update_ndev_stats(struct aq_nic_s *self);
>> 
>> Please do not add driver private module parameter knobs like this.
>> 
>> Instead, please use a existing, device agnostic, runtime,
>> configuration mechanism to control this.
> 
> I'm not aware of any existing standard way to configure tx cleanup budget.
> Many drivers just have it hardcoded via define. Is that what you suggest then?

You can hard code it, or find some way to make ethtool support this and
therefore make the configuration available generically for all drivers
which may want to allow tweaking this.