netdev - RE: DTS for our Configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <48F7D4389F30BA4383F214EE802BA47101706554EB@EXS10.iai.co.il>
Date:   Mon, 19 Mar 2018 16:23:11 +0000
From:   Alayev Michael <malayev@....co.il>
To:     "'andrew@...n.ch'" <andrew@...n.ch>
CC:     "'netdev@...r.kernel.org'" <'netdev@...r.kernel.org'>,
        Efter Yoram <yefter@....co.il>, Dror Alon <adror@....co.il>
Subject: RE: DTS for our Configuration

Hello Andrew,

You deserve a big thank you for your solution to our device-tree - the linux bootup log looks a lot better and It made a big progress for us.
Though we still have some issues...

1. Attached are 2 log files that are the result of your suggested dts:
	1st is your device-tree as is : results in kernel panic. Its probably caused by the "link" parameter.
	2nd is your device tree with gem0 port's10 "link" parameter commented on both switches. It results in good kernel but still the devices are not properly detected. Maybe its related to the 	comment you wrote below about the fixed PHY driver issue that prevents the driver to complete his phy address scan (stops at phy addr 1...).
2. The switch's product number should be 0x0a1 but instead its 0xa10 (is it just a high-low byte thing?)
3. The stand-alone phy (gem1) is not detected properly. It should be device id mv88e1510.

Please advise how to continue from here.

Regards,
Michael Alayev



-----Original Message-----
From: Dror Alon 
Sent: Sunday, March 18, 2018 8:16 AM
To: Alayev Michael
Subject: FW: DTS for our Configuration



-----Original Message-----
From: Andrew Lunn [mailto:andrew@...n.ch]
Sent: Friday, March 16, 2018 5:12 PM
To: Dror Alon
Cc: 'netdev@...r.kernel.org'; Efter Yoram; Alayev Michael
Subject: Re: DTS for our Configuration

On Thu, Mar 15, 2018 at 02:00:00PM +0000, Dror Alon wrote:
> Hello Andrew,
> Thanks for your fast responses.
> Michael and I keep trying to configure our linux Zynq7000 board.
> We can't succeed with configure our SWITCHES via the DTS file.

> Please. See the next diagram, and please Do you have any DTS Sample 
> for this Setup ?

Hi Dror

I'm surprised you are doing SGMII between ports 10. They are 10G capable.

gem0: {
	fixed-link {
		speed = <1000>;
		full-duplex;
	};

	phy0: phy@0: {
		reg = <0>;
	};

	switch0: switch@1c: {
		compatible = "marvell,mv88e6190";
		reg = <0x1c>;

		ports {
			#address-cells = <1>;
			#size-cells = <0>;

			port@0 {
				reg = <0>;
				label = "cpu";
				fixed-link {
					speed = <1000>;
					full-duplex;
				};
			port@1 {
				reg = <1>;
				label = "lan0";
			};
			port@2 {
				reg = <2>;
				label = "lan1";
			};
			...
			switch0port10: port@10 {
				reg = <10>;
				label = "dsa";
				link = <&switch1port10>;
				phy-mode = "sgmii";
			 	fixed-link {
					speed = <1000>;
					full-duplex;
				};
			};
		};
	};

	switch1: switch@1d: {
		compatible = "marvell,mv88e6190";
		reg = <0x1d>;

		ports {
			#address-cells = <1>;
			#size-cells = <0>;

			port@0 {
				reg = <0>;
				label = "lan9";
				};
			port@1 {
				reg = <1>;
				label = "lan10";
			};
			port@2 {
				reg = <2>;
				label = "lan11";
			};
			...
			switch1port10: port@10 {
				reg = <10>;
				label = "dsa";
				link = <&switch0port10>;
				phy-mode = "sgmii";
			 	fixed-link {
					speed = <1000>;
					full-duplex;
				};
			};
		};
	};
};

gem1: {
      phy-handle = <phy0>;
};

It looks like you have at last one issue to solve in the macb driver.
If you have a fixed-phy, it does an mdiobus_register. This means it is going to ignore all the other device tree properties. You need it to do an of_mdiobus_register().

   Andrew

Default Profile
***********************************************************************************************

Please consider the environment before printing this email !
The information contained in this communication is proprietary to Israel Aerospace Industries Ltd. and/or third parties, may contain confidential or privileged information, and is intended only for the use of the intended addressee thereof.
If you are not the intended addressee, please be aware that any use, disclosure, distribution and/or copying of this communication is strictly prohibited. If you receive this communication in error, please notify the sender immediately and delete it from your computer. 
Thank you.

Visit us at:   www.iai.co.il

View attachment "linux_log_andrew_dts_original.txt" of type "text/plain" (12164 bytes)

View attachment "
	"linux_log_andrew_dts_with_Port10in_both_switches_and_no_link.txt"" of type "text/plain" (8926 bytes)

Download attachment "zynq-zed.dts" of type "application/octet-stream" (4384 bytes)