netdev - Re: [PATCH 0/4] net: dsa: mv88e6xxx: novice fixes and irq handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180319163713.GH26039@lunn.ch>
Date:   Mon, 19 Mar 2018 17:37:13 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>
Cc:     Vivien Didelot <vivien.didelot@...oirfairelinux.com>,
        Marc Zyngier <marc.zyngier@....com>,
        Thomas Gleixner <tglx@...utronix.de>, kernel@...gutronix.de,
        Florian Fainelli <f.fainelli@...il.com>,
        netdev@...r.kernel.org,
        Gregory CLEMENT <gregory.clement@...e-electrons.com>
Subject: Re: [PATCH 0/4] net: dsa: mv88e6xxx: novice fixes and irq handling

> 	interrupt-parent = <&gpiosb>;
> 	interrupts = <23 IRQ_TYPE_LEVEL_LOW>;
> 
> to the switch of the espressobin's dtb, the irq couldn't be used. The
> reason is the interaction of several things:
> 
>  - On the first try to probe the switch, the driver did:
> 
> 	irq = of_irq_get(np, 0);
> 	request_threaded_irq(irq, NULL, func, IRQF_ONESHOT | IRQF_TRIGGER_FALLING, ...);

Hi Uwe

It looks like we should just drop IRQF_TRIGGER_FALLING from here. The
interrupt trigger will be configured by of_irq_get(). All the current
DT files actually list it as IRQ_TYPE_LEVEL_LOW.

> When I tested the second change however the driver still failed
> because the gpio controller doesn't support level sensitive
> irqs. :-|

Do you have documentation for the SoC? Is it a hardware limitation, or
just missing from the pinctrl driver?

     Andrew