netdev - Re: [PATCH v12 net-next 01/12] tls: support for Inline tls record

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180319175744.6c4523ea@epycfail>
Date:   Mon, 19 Mar 2018 17:57:44 +0100
From:   Stefano Brivio <sbrivio@...hat.com>
To:     Atul Gupta <atul.gupta@...lsio.com>
Cc:     davem@...emloft.net, herbert@...dor.apana.org.au,
        davejwatson@...com, sd@...asysnail.net,
        linux-crypto@...r.kernel.org, netdev@...r.kernel.org,
        ganeshgr@...lsio.com, Julia Lawall <julia.lawall@...6.fr>
Subject: Re: [PATCH v12 net-next 01/12] tls: support for Inline tls record

On Mon, 19 Mar 2018 19:25:34 +0530
Atul Gupta <atul.gupta@...lsio.com> wrote:

> @@ -268,6 +259,8 @@ static void tls_sk_proto_close(struct sock *sk, long timeout)
>  skip_tx_cleanup:
>  	release_sock(sk);
>  	sk_proto_close(sk, timeout);
> +	if (ctx && ctx->tx_conf == TLS_HW_RECORD)
> +		kfree(ctx);

Why are you still dereferencing ctx after it has been freed, as
reported by Julia (<alpine.DEB.2.20.1803181700230.2420@...rien>) on v11?

-- 
Stefano