lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 20 Mar 2018 15:30:56 +0100 From: Andrew Lunn <andrew@...n.ch> To: Vicentiu Galanopulo <vicentiu.galanopulo@....com> Cc: f.fainelli@...il.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, robh+dt@...nel.org, mark.rutland@....com, davem@...emloft.net, marcel@...tmann.org, devicetree@...r.kernel.org, madalin.bucur@....com, alexandru.marginean@....com Subject: Re: [RFC PATCH] net: phy: Added device tree binding for dev-addr and dev-addr code check-up and usage On Tue, Mar 20, 2018 at 08:46:15AM -0500, Vicentiu Galanopulo wrote: > Reason for this patch is that the Inphi PHY > has a vendor specific address space for accessing > the C45 MDIO registers - starting from 0x1e. > > A new function has been added, get_phy_c45_dev_addr, > which loops through all the PHY device nodes under > a MDIO bus node and looks for the <dev-addr> property. If > it's not set/found, the get_phy_c45_devs_in_pkg, > will be called with the value 0 as dev_addr parameter, > else it will be called with the dev-addr property > value from the device tree. This seems like the wrong way to implement this. How about: of_mdiobus_register(), when it loops over the children, looks for the new property. If found, it passed dev-id to of_mdiobus_register_phy(). That passes it to get_phy_device(). I think get_phy_device() can then set the ID in c45_ids, before passing it to get_phy_id(). get_phy_c45_ids() will first look at devices in package and can add further devices to c45_ids. It will then probe both those found, and the static one you added. Andrew
Powered by blists - more mailing lists