netdev - Re: [PATCH net] ipv6: old_dport should be a __be16 in __ip6_datagram

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180320160929.GM1351@alphalink.fr>
Date:   Tue, 20 Mar 2018 17:09:29 +0100
From:   Guillaume Nault <g.nault@...halink.fr>
To:     Stefano Brivio <sbrivio@...hat.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Paolo Abeni <pabeni@...hat.com>, Wei Wang <weiwan@...gle.com>,
        netdev@...r.kernel.org
Subject: Re: [PATCH net] ipv6: old_dport should be a __be16 in
 __ip6_datagram_connect()

On Mon, Mar 19, 2018 at 11:24:58AM +0100, Stefano Brivio wrote:
> Fixes: 2f987a76a977 ("net: ipv6: keep sk status consistent after datagram connect failure")
> Signed-off-by: Stefano Brivio <sbrivio@...hat.com>
> Acked-by: Paolo Abeni <pabeni@...hat.com>
> ---
>  net/ipv6/datagram.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/ipv6/datagram.c b/net/ipv6/datagram.c
> index 8a9ac2d0f5d3..a9f7eca0b6a3 100644
> --- a/net/ipv6/datagram.c
> +++ b/net/ipv6/datagram.c
> @@ -149,7 +149,7 @@ int __ip6_datagram_connect(struct sock *sk, struct sockaddr *uaddr,
>  	struct in6_addr		*daddr, old_daddr;
>  	__be32			fl6_flowlabel = 0;
>  	__be32			old_fl6_flowlabel;
> -	__be32			old_dport;
> +	__be16			old_dport;
>  	int			addr_type;
>  	int			err;
>  
Acked-by: Guillaume Nault <g.nault@...halink.fr>