netdev - Re: [PATCH net-next] fib_rules: rename FRA_PROTOCOL to FRA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <73742889-4982-410f-2128-82dcd85f1147@gmail.com>
Date:   Tue, 20 Mar 2018 11:27:19 -0600
From:   David Ahern <dsahern@...il.com>
To:     Nicolas Dichtel <nicolas.dichtel@...nd.com>, davem@...emloft.net
Cc:     netdev@...r.kernel.org, Donald Sharp <sharpd@...ulusnetworks.com>
Subject: Re: [PATCH net-next] fib_rules: rename FRA_PROTOCOL to FRA_ORIGINATOR

On 3/20/18 11:04 AM, Nicolas Dichtel wrote:
> As the comment said, this attribute defines the originator of the rule,
> it's not really a (network) protocol.
> Let's rename it accordingly to avoid confusion (difference between
> FRA_PROTOCOL and FRA_IP_PROTO was not obvious).
> 
> CC: Donald Sharp <sharpd@...ulusnetworks.com>
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>
> ---
> 
> FRA_PROTOCOL exists only in net-next for now, thus it's still possible to
> rename it.
> 
>  drivers/net/vrf.c              |  4 ++--
>  include/net/fib_rules.h        |  4 ++--
>  include/uapi/linux/fib_rules.h |  2 +-
>  net/core/fib_rules.c           | 14 +++++++-------
>  4 files changed, 12 insertions(+), 12 deletions(-)
> 
>

This protocol is meant to be analogous to rtm_protocol. Changing the
name to FRA_ORIGINATOR loses that connection.