netdev - Re: [PATCH] vmxnet3: fix LRO feature check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.10.1803201140130.23969@shri-linux.eng.vmware.com>
Date:   Tue, 20 Mar 2018 11:42:47 -0700
From:   Shrikrishna Khare <skhare@...i-linux.eng.vmware.com>
To:     David Miller <davem@...emloft.net>
CC:     <lkp@...el.com>, <ipylypiv@...ver-peak.com>, <kbuild-all@...org>,
        <skhare@...are.com>, <pv-drivers@...are.com>,
        <netdev@...r.kernel.org>
Subject: Re: [PATCH] vmxnet3: fix LRO feature check



On Tue, 20 Mar 2018, David Miller wrote:

> From: kbuild test robot <lkp@...el.com>
> Date: Sun, 18 Mar 2018 14:37:35 +0800
> 
> > All warnings (new ones prefixed by >>):
> > 
> >    drivers/net/vmxnet3/vmxnet3_drv.c: In function 'vmxnet3_rq_rx_complete':
> >>> drivers/net/vmxnet3/vmxnet3_drv.c:1474:8: warning: suggest parentheses around operand of '!' or change '&' to '&&' or '!' to '~' [-Wparentheses]
> >            !adapter->netdev->features & NETIF_F_LRO) {
> >            ^~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> Igor, I will fix this up for you.  But it is clear that this patch wasn't tested
> very well.
> 
> Because !adapter->netdev->features evaluates wholly before the "& NETIF_F_LRO",
> the flags aren't being tested properly at all.

Ronak's patch that fixes this issue has the right code, and is already 
accepted in net tree (Commit: 034f405793897a3c8f642935f5494b86c340cde7). 
We no longer need Igor's patch.

Thanks,
Shri