netdev - Re: rfc: treewide replace local ethernet broadcast char arrays with a global ?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 20 Mar 2018 13:07:27 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Joe Perches <joe@...ches.com>, netdev <netdev@...r.kernel.org>
Subject: Re: rfc: treewide replace local ethernet broadcast char arrays with a
 global ?

On 03/20/2018 01:00 PM, Joe Perches wrote:
> Treewide there are ~60 declarations of a ethernet broadcast
> address as a 6 byte array that are later used as either an
> output for vsprintf extension %pM or as a source array to
> copy or compare.
> 
> Perhaps it'd be useful to declare a global static const u8[]
> in net somewhere instead to save the text/data space of these
> duplicate declarations.

I could have sworn that such a thing existed already within
include/linux/etherdevice.h but it is only eth_reserved_addr_base and
friends as well as is_broadcast_ether_addr(). How about you do it?

> 
> $ grep-2.5.4 -n --include=*.[ch] "\b(?:static\s+)?(?:const\s+)?(?:char|unsigned\s+char|u8)\s+\w+\s*\[\s*(?:ETH_ALEN|6)\s*\]\s*=\s*\{\s*(?:(?i:0xff|255),\s*){5,5}\s*(?i:0xff|255)\s*\}" * | \
>   grep -P "\.[ch]:\d+:"
> 

-- 
Florian