netdev - Re: [PATCH v2 net-next 2/5] cxgb4: Add support to initialise/read SRQ entries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180320075839.69dd90d4@epycfail>
Date:   Tue, 20 Mar 2018 07:58:39 +0100
From:   Stefano Brivio <sbrivio@...hat.com>
To:     Raju Rangoju <rajur@...lsio.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, nirranjan@...lsio.com,
        indranil@...lsio.com, venkatesh@...lsio.com,
        swise@...ngridcomputing.com, bharat@...lsio.com,
        Ganesh Goudar <ganeshgr@...lsio.com>
Subject: Re: [PATCH v2 net-next 2/5] cxgb4: Add support to initialise/read
 SRQ entries

On Tue, 20 Mar 2018 11:43:34 +0530
Raju Rangoju <rajur@...lsio.com> wrote:

> +struct srq_data *t4_init_srq(int srq_size)
> +{
> +	struct srq_data *s;
> +
> +	s = kzalloc(sizeof(*s), GFP_KERNEL | __GFP_NOWARN);
> +	if (!s)
> +		s = kvzalloc(sizeof(*s), GFP_KERNEL);
> +	if (!s)
> +		return NULL;

I meant: you can replace this whole fragment by kzalloc(), which does
what you want, in the right way. LWN has a nice write-up at:
https://lwn.net/Articles/711653/

-- 
Stefano