netdev - Re: [PATCH] kbuild: disable clang's default use of -fmerge-all-constants

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bd7b0d23-519e-ca8b-a768-1440a4bc90d3@iogearbox.net>
Date:   Wed, 21 Mar 2018 01:38:45 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     Alexei Starovoitov <ast@...nel.org>, psodagud@...eaurora.org,
        Network Development <netdev@...r.kernel.org>,
        Chenbo Feng <fengc@...gle.com>,
        Richard Smith <richard-llvm@...afoo.co.uk>,
        Chandler Carruth <chandlerc@...il.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] kbuild: disable clang's default use of
 -fmerge-all-constants

On 03/21/2018 01:36 AM, Linus Torvalds wrote:
> On Tue, Mar 20, 2018 at 5:18 PM, Daniel Borkmann <daniel@...earbox.net> wrote:
>> Prasad reported that he has seen crashes in BPF subsystem with netd
>> on Android with arm64 in the form of (note, the taint is unrelated):
> 
> Ack. This looks good to me. And thanks for noticing the behavior wrt
> the correct gcc merging.
> 
>>  [ Hi Linus, feel free to take this fix directly if you want.
>>    Alternatively, we could route it via bpf tree. Thanks a
>>    lot for your feedback! ]
> 
> So since it's your patch and the only known issue comes from the bpf
> side, I think it should just go through the bpf tree, and I expect it
> to get to me through all the usual channels.

Yeah, that's fine, thanks for letting us know!

Best,
Daniel