netdev - Re: [PATCH] macsec: missing dev_put() on error in macsec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180322.143104.2174553329772161672.davem@davemloft.net>
Date:   Thu, 22 Mar 2018 14:31:04 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     dan.carpenter@...cle.com
Cc:     sd@...asysnail.net, dsahern@...il.com, dwindsor@...il.com,
        elena.reshetova@...el.com, Jason@...c4.com,
        mschiffer@...verse-factory.net, johannes.berg@...el.com,
        felix.walter@...udandheat.com, girish.moodalbail@...cle.com,
        netdev@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] macsec: missing dev_put() on error in macsec_newlink()

From: Dan Carpenter <dan.carpenter@...cle.com>
Date: Wed, 21 Mar 2018 11:09:01 +0300

> We moved the dev_hold(real_dev); call earlier in the function but forgot
> to update the error paths.
> 
> Fixes: 0759e552bce7 ("macsec: fix negative refcnt on parent link")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Applied and queued up for -stable, thanks Dan.