netdev - Re: [PATCH] caif_dev: use true and false for boolean values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <dc5dfef0-2895-3fa9-8fc1-878e63cea3f0@embeddedor.com>
Date:   Thu, 22 Mar 2018 14:24:54 -0500
From:   "Gustavo A. R. Silva" <garsilva@...eddedor.com>
To:     Dmitry Tarnyagin <dmitry.tarnyagin@...kless.no>,
        "David S. Miller" <davem@...emloft.net>
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] caif_dev: use true and false for boolean values

Hi all,

I was just wondering about the status of this patch.

Thanks!
--
Gustavo

On 03/05/2018 04:05 PM, Gustavo A. R. Silva wrote:
> Assign true or false to boolean variables instead of an integer value.
> 
> This issue was detected with the help of Coccinelle.
> 
> Signed-off-by: Gustavo A. R. Silva <garsilva@...eddedor.com>
> ---
>   net/caif/caif_dev.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/net/caif/caif_dev.c b/net/caif/caif_dev.c
> index e0adcd1..f2848d6 100644
> --- a/net/caif/caif_dev.c
> +++ b/net/caif/caif_dev.c
> @@ -139,7 +139,7 @@ static void caif_flow_cb(struct sk_buff *skb)
>   
>   	spin_lock_bh(&caifd->flow_lock);
>   	send_xoff = caifd->xoff;
> -	caifd->xoff = 0;
> +	caifd->xoff = false;
>   	dtor = caifd->xoff_skb_dtor;
>   
>   	if (WARN_ON(caifd->xoff_skb != skb))
> @@ -213,7 +213,7 @@ static int transmit(struct cflayer *layer, struct cfpkt *pkt)
>   	pr_debug("queue has stopped(%d) or is full (%d > %d)\n",
>   			netif_queue_stopped(caifd->netdev),
>   			qlen, high);
> -	caifd->xoff = 1;
> +	caifd->xoff = true;
>   	caifd->xoff_skb = skb;
>   	caifd->xoff_skb_dtor = skb->destructor;
>   	skb->destructor = caif_flow_cb;
> @@ -400,7 +400,7 @@ static int caif_device_notify(struct notifier_block *me, unsigned long what,
>   			break;
>   		}
>   
> -		caifd->xoff = 0;
> +		caifd->xoff = false;
>   		cfcnfg_set_phy_state(cfg, &caifd->layer, true);
>   		rcu_read_unlock();
>   
> @@ -435,7 +435,7 @@ static int caif_device_notify(struct notifier_block *me, unsigned long what,
>   		if (caifd->xoff_skb_dtor != NULL && caifd->xoff_skb != NULL)
>   			caifd->xoff_skb->destructor = caifd->xoff_skb_dtor;
>   
> -		caifd->xoff = 0;
> +		caifd->xoff = false;
>   		caifd->xoff_skb_dtor = NULL;
>   		caifd->xoff_skb = NULL;
>   
>