netdev - Re: [net-next:master 304/314] drivers/net/ethernet/mellanox/mlxsw/spectrum.c:3878:8: error: too few arguments to function 'devlink_resource

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f73cb212-b286-ca17-c42a-ab7398d8be82@gmail.com>
Date:   Fri, 23 Mar 2018 08:33:43 -0600
From:   David Ahern <dsahern@...il.com>
To:     Jiri Pirko <jiri@...nulli.us>
Cc:     kbuild test robot <fengguang.wu@...el.com>, kbuild-all@...org,
        netdev@...r.kernel.org
Subject: Re: [net-next:master 304/314]
 drivers/net/ethernet/mellanox/mlxsw/spectrum.c:3878:8: error: too few
 arguments to function 'devlink_resource_register'

On 3/23/18 12:53 AM, Jiri Pirko wrote:
> Fri, Mar 23, 2018 at 02:53:38AM CET, dsahern@...il.com wrote:
>> On 3/22/18 6:47 PM, kbuild test robot wrote:
>>> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master
>>> head:   6686c459e1449a3ee5f3fd313b0a559ace7a700e
>>> commit: 145307460ba9c11489807de7acd3f4c7395f60b7 [304/314] devlink: Remove top_hierarchy arg to devlink_resource_register
>>> config: x86_64-randconfig-s1-03230751 (attached as .config)
>>> compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026
>>> reproduce:
>>>         git checkout 145307460ba9c11489807de7acd3f4c7395f60b7
>>>         # save the attached .config to linux build tree
>>>         make ARCH=x86_64 
>>>
>>> All error/warnings (new ones prefixed by >>):
>>>
>>>    drivers/net/ethernet/mellanox/mlxsw/spectrum.c: In function 'mlxsw_sp_resources_register':
>>>>> drivers/net/ethernet/mellanox/mlxsw/spectrum.c:3881:6: warning: passing argument 6 of 'devlink_resource_register' makes integer from pointer without a cast [-Wint-conversion]
>>>          &kvd_size_params,
>>>          ^
>>>    In file included from drivers/net/ethernet/mellanox/mlxsw/core.h:47:0,
>>>                     from drivers/net/ethernet/mellanox/mlxsw/spectrum.h:54,
>>>                     from drivers/net/ethernet/mellanox/mlxsw/spectrum.c:64:
>>>    include/net/devlink.h:560:1: note: expected 'u64 {aka long long unsigned int}' but argument is of type 'struct devlink_resource_size_params *'
>>>     devlink_resource_register(struct devlink *devlink,
>>>     ^~~~~~~~~~~~~~~~~~~~~~~~~
>>
>> I just did another full build (allmodconfig) on net-next and did not hit
>> this error.
> 
> The "else branch" in "#if IS_ENABLED(CONFIG_NET_DEVLINK)" is the
> problem:
> 
> static inline int
> devlink_resource_register(struct devlink *devlink,
>                           const char *resource_name,
>                           bool top_hierarchy,
>                           u64 resource_size,
>                           u64 resource_id,
>                           u64 parent_resource_id,
>                           const struct devlink_resource_size_params *size_params,
>                           const struct devlink_resource_ops *resource_ops)
> {
>         return 0;
> }
> 

ugh. Thanks, Jiri. Will fix.