netdev - Re: [PATCH net-next 2/2] net: Drop NETDEV_UNREGISTER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 23 Mar 2018 10:15:43 -0600
From:   Jason Gunthorpe <jgg@...pe.ca>
To:     Kirill Tkhai <ktkhai@...tuozzo.com>
Cc:     davem@...emloft.net, Michal.Kalderon@...ium.com,
        Ariel.Elior@...ium.com, dledford@...hat.com, benve@...co.com,
        1dgoodell@...co.com, daniel@...earbox.net,
        jakub.kicinski@...ronome.com, ast@...nel.org, edumazet@...gle.com,
        linux@...musvillemoes.dk, john.fastabend@...il.com,
        brouer@...hat.com, dsahern@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 2/2] net: Drop NETDEV_UNREGISTER_FINAL

On Fri, Mar 23, 2018 at 12:39:33PM +0300, Kirill Tkhai wrote:
> Last user is gone after bdf5bd7f2132 "rds: tcp: remove
> register_netdevice_notifier infrastructure.", so we can
> remove this netdevice command. This allows to delete
> rtnl_lock() in netdev_run_todo(), which is hot path for
> net namespace unregistration.
> 
> dev_change_net_namespace() and netdev_wait_allrefs()
> have rcu_barrier() before NETDEV_UNREGISTER_FINAL call,
> and the source commits say they were introduced to
> delemit the call with NETDEV_UNREGISTER, but this patch
> leaves them on the places, since they require additional
> analysis, whether we need in them for something else.
> 
> Signed-off-by: Kirill Tkhai <ktkhai@...tuozzo.com>
>  drivers/infiniband/hw/qedr/main.c |    4 ++--
>  include/linux/netdevice.h         |    1 -
>  include/rdma/ib_verbs.h           |    4 ++--
>  net/core/dev.c                    |    6 ------
>  4 files changed, 4 insertions(+), 11 deletions(-)

No problem to take the rdma part of this through netdev

Acked-by: Jason Gunthorpe <jgg@...lanox.com>

Jason