netdev - Re: [PATCH v2 net-next 0/6] TLS Rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180323.122747.1259445861280768136.davem@davemloft.net>
Date:   Fri, 23 Mar 2018 12:27:47 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     davejwatson@...com
Cc:     tom@...ntonium.net, alexei.starovoitov@...il.com,
        herbert@...dor.apana.org.au, linux-crypto@...r.kernel.org,
        netdev@...r.kernel.org, borisp@...lanox.com,
        atul.gupta@...lsio.com, vakul.garg@....com,
        hannes@...essinduktion.org, steffen.klassert@...unet.com,
        john.fastabend@...il.com, daniel@...earbox.net
Subject: Re: [PATCH v2 net-next 0/6] TLS Rx

From: Dave Watson <davejwatson@...com>
Date: Thu, 22 Mar 2018 10:09:44 -0700

> TLS tcp socket RX implementation, to match existing TX code.

Looks great Dave.  Applied, and once my build tests finish I'll push
this out to net-next.

In some of the new functions, reverse christmas tree ordering of local
variables was not adhered to.

I know it can be difficult in some situations, but please fix this up in
followon patches.  You can move the assignments down into the function
body to accomodate this, if necessary.

Thanks.