netdev - Re: [PATCH 0/2] bpf: Change print_bpf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c77e304f-8c4a-7e2e-dcb7-961190b13956@iogearbox.net>
Date:   Fri, 23 Mar 2018 17:47:40 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Quentin Monnet <quentin.monnet@...ronome.com>,
        Jiri Olsa <jolsa@...nel.org>,
        Alexei Starovoitov <ast@...nel.org>
Cc:     lkml <linux-kernel@...r.kernel.org>, netdev@...r.kernel.org
Subject: Re: [PATCH 0/2] bpf: Change print_bpf_insn interface

On 03/23/2018 02:34 PM, Quentin Monnet wrote:
> 2018-03-23 11:41 UTC+0100 ~ Jiri Olsa <jolsa@...nel.org>
>> hi,
>> this patchset removes struct bpf_verifier_env argument
>> from print_bpf_insn function (patch 1) and changes user
>> space bpftool user to use it that way (patch 2).
>>
>> thanks,
>> jirka
>>
>> ---
>> Jiri Olsa (2):
>>       bpf: Remove struct bpf_verifier_env argument from print_bpf_insn
>>       bpftool: Adjust to new print_bpf_insn interface
>>
>>  kernel/bpf/disasm.c               | 52 ++++++++++++++++++++++++++--------------------------
>>  kernel/bpf/disasm.h               |  5 +----
>>  kernel/bpf/verifier.c             | 44 +++++++++++++++++++++++++++-----------------
>>  tools/bpf/bpftool/xlated_dumper.c | 12 ++++++------
>>  4 files changed, 60 insertions(+), 53 deletions(-)
>>
> 
> Thanks, this version looks good to me. Please keep the "Reviewed-by"
> tags when resubmitting new versions of your patch sets :)
> 
> For the series:
> Reviewed-by: Quentin Monnet <quentin.monnet@...ronome.com>

Applied to bpf-next, thanks everyone!